Fix text alignment in invocation grid rows#22158
Draft
dannon wants to merge 1 commit intogalaxyproject:devfrom
Draft
Fix text alignment in invocation grid rows#22158dannon wants to merge 1 commit intogalaxyproject:devfrom
dannon wants to merge 1 commit intogalaxyproject:devfrom
Conversation
Member
Author
|
Marking as draft — I want to add before/after screenshots and verify this doesn't have unintended consequences on other grid pages or SwitchToHistoryLink usages before requesting review. |
SwitchToHistoryLink's flex container used space-between and center, which pushed the archive/purge icon far right and vertically centered it against multi-line text. Switched to baseline and dropped space-between. Also, GLink renders as a button when no href/to is provided and browsers default buttons to text-align: center — used a scoped deep selector to override this so wrapped history names stay left-aligned. Fixes galaxyproject#21143.
dannon
force-pushed
the
fix/invocation-menu-text-alignment
branch
from
be05608 to
dcdc9eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21143.
The history name in SwitchToHistoryLink had two alignment issues when wrapping to multiple lines:
The flex container used
justify-content: space-betweenandalign-items: center, which pushed the archive/purge icon to the far right and vertically centered it against multi-line text. Switched tobaselineand droppedspace-between.GLink renders as a
<button>when nohref/toprop is provided, and browsers default buttons totext-align: center. On single-line text this is invisible, but wrapped text center-aligns each line. Used a scoped:deep()selector to override this on the history link.